Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove theme overrides from inclusion #1065

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thrameos
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #1065 (e5339f6) into master (faa41f7) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   88.63%   88.66%   +0.02%     
==========================================
  Files         112      112              
  Lines       10235    10235              
  Branches     4012     4012              
==========================================
+ Hits         9072     9075       +3     
+ Misses        703      702       -1     
+ Partials      460      458       -2     
Impacted Files Coverage Δ
native/common/jp_methoddispatch.cpp 87.03% <0.00%> (+0.92%) ⬆️
native/common/jp_method.cpp 98.84% <0.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c710b9e...e5339f6. Read the comment docs.

@pelson
Copy link
Contributor

pelson commented Jul 4, 2022

The file in _static/theme_overrides.css should also be removed.

Confirming that in the built docs, there are no use of the only element that that file overrides, namely wy-table-responsive. Grepping the built docs:

$ grep "wy-table-responsive"  ./_build/ -r -l
./_build/html/_static/css/theme.css
./_build/html/_static/js/theme.js
./_build/html/_static/theme_overrides.css

@pelson
Copy link
Contributor

pelson commented Jul 4, 2022

Confirming that in the built docs, there are no use of the only element that that file overrides

Actually, I realise that this means very little, since the theme.js file injects table class types, so this override is active. I can't actually observe the behaviour that the override is trying to fix though.

@marscher marscher added this to the 1.5 milestone Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants