Gauntlet 7 sorrows #1347
Open
Gauntlet 7 sorrows #1347
+272
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigianb
commented
Feb 1, 2024
Source/ee/VuBasicBlock.cpp
Outdated
| { | ||
| // we need to use the value of intReg 3 steps prior or use initial value. | ||
| result.regIndex = endLoOps.writeI; | ||
| result.saveRegAddress = std::max<int32>(adjustedEnd - 5 * 8, m_begin); |
There was a problem hiding this comment.
I'm not convinced on the 5 value here - I think it may need to be 4.
jpd002
reviewed
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the VU edge case where an integer altering instruction is in the delay slot of a conditional branch and the first instruction following it is another conditional branch based on that integer register.
The original code will take the value of the integer register at that time assuming a pipeline shortcut but that is wrong because having an integer altering instruction directly before a conditional branch on that same integer register causes the pipeline to fail and we need to use the value most recently written to memory.
Can potentially break a lot of games so needs quite a bit of testing.