Fix generation failure when multiple type parameters are in the receiver #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josharian
reviewed
Apr 23, 2024
| @@ -82,6 +82,12 @@ func getReceiverType(recv string) string { | |||
| // VSCode adds a trailing space to receiver (it runs impl like: impl 'r *Receiver ' io.Writer) | |||
| // so we have to remove spaces. | |||
| recv = strings.TrimSpace(recv) | |||
|
|
|||
| // Remove type parameters. They can contain spaces too, for example 'r *Receiver[T, U]'. | |||
|
Sorry, just found a bug, will fix and write a test |
Also fixes duplicate method generation for already implemented methods of structs with type parameters.
ArtAndreev
force-pushed
the
fix_multiple_type_parameters
branch
from
c6912be
to
4ff6050
Compare
The bug duplicated method generation for already implemented methods of structs with type parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before generation failed when receiver had multiple type parameters. For example,
impl 'n *Node[T, U]' fmt.Stringerproduced an errorinvalid receiver: "n *Node[T, U]".