Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Panic Key #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle Panic Key #13

wants to merge 3 commits into from

Conversation

hairpeace0
Copy link

Receive Panic Key (messagetype=11, note=123) and disable all
playingnotes

@hairpeace0
Handle Panic Key
5a6d187 
Receive Panic Key (messagetype=11, note=123) and disable all
playingnotes
@hairpeace0
Don't fill empty notes for non melodic instrument (ie: drums)
c702dd3 
For programs like drums, create a file "config.txt"  in the program
folder and add the following line:
melodicProgram=false
@hairpeace0
...
181fa9b 
For programs like drums, create a file "config.txt"  in the program
folder and add the following line:
melodic=false
@josephernest
Copy link
Owner

josephernest commented Aug 8, 2022 •
edited

Hello @hairpeace0, thanks for this PR! I'm a bit late of 5 years lol
I wanted to merge your PR, after a few small edits. Could you edit your PR / commits, to include the Allow edits from maintainers option. This allows me to do a few modifications before merging:

@josephernest
Copy link
Owner

Useful note for later: http://midi.teragonaudio.com/tech/midispec/ntnoff.htm

All Notes Off
Number: 123

Turns off all notes that were turned on by received Note On messages, and which haven't yet been turned off by respective Note Off messages. This message is not supposed to turn off any notes that the musician is playing on the local keyboard. So, if a device can't distinguish between notes played via its MIDI IN and notes played on the local keyboard, it should not implement All Notes Off. Furthermore, if a device is in Omni On state, it should ignore this message on any channel.

Note: If the device's Hold Pedal controller is on, the notes aren't actually released until the Hold Pedal is turned off. See All Sound Off controller message for turning off the sound of these notes immediately.

@dosas
Copy link

dosas commented Apr 23, 2024

@josephernest What exactly do you want to edit. Can't you propose the changes you want to see?

@josephernest
Copy link
Owner

@hairpeace0 I want to merge the first commit only (5a6d187) but not the 2nd and the 3rd.

Indeed adding a second definition file for an instrument (config.txt in addition to already-existing definition.txt) is not wanted. Also we don't want to make a specific definition-file parsing here: c702dd3#diff-12abeff96b5d42b373fde683a1301f9bd00c7f4c06dd7dfc6f2198e2809e915bR333.

How, in Github, to merge only the 1st commit of this PR, but not the 2nd + 3rd @dosas ?

@dosas
Copy link

dosas commented Apr 24, 2024

I see two possibilities:

Either the contributor rebases his changes and deletes the 2nd and 3rd commit

If the contributor does not react. You could cherry pick the first commit and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hairpeace0 @josephernest @dosas