Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring 3 #44

Closed
wants to merge 1 commit into from
Closed

Upgrade to Spring 3 #44

wants to merge 1 commit into from

Conversation

mslowiak
Copy link
Collaborator

@mslowiak mslowiak commented Apr 1, 2023

Closes: #43

@mslowiak mslowiak requested a review from josdem April 1, 2023 15:12
@mslowiak
Copy link
Collaborator Author

mslowiak commented Apr 1, 2023

@josdem working on my side but please test it on your side as well because it is big change

@mslowiak
Copy link
Collaborator Author

mslowiak commented Apr 1, 2023

I found out problems with tests, changing to draft

@mslowiak mslowiak marked this pull request as draft April 1, 2023 23:59
@josdem
Copy link
Owner

josdem commented Apr 2, 2023

Hi @mslowiak, thanks for creating a PR to update to spring 3.0.5 this is the error I am seeing when running tests or trying to start the application:

Caused by: java.lang.ClassNotFoundException: javax.servlet.http.HttpServletRequest
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:467)

Not sure why this is happening. I will investigate this in detail

@mslowiak
Copy link
Collaborator Author

mslowiak commented Apr 2, 2023

I think that the springfox is the problem here - it is not yet compatible with Spring 3.
springfox/springfox#3983

If we want to move to the Spring 3, then we should migrate springfox to springdoc, see migration guide

@josdem
Copy link
Owner

josdem commented Apr 2, 2023

I agree; springfox is the issue here. We want to migrate to Spring Doc as the next step. I went ahead and create a new issue in the repository, please take a look at it here

@mslowiak mslowiak mentioned this pull request May 5, 2023
@mslowiak mslowiak closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Spring 3
2 participants