Fix button modal #512
Open
Fix button modal #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <?php else : ?> | ||
| <li class="list-group mt-3"> | ||
| <?php endif; ?> | ||
| <li class="list-group mt-3"> |
There was a problem hiding this comment.
I think we should leave the class system-unpublished as how it is. It gives a way to allow target unpublished weblink items (note that on this page, we also display unpublished items for users with core.edit or core.edit.state permission) via css if needed. For your information, we also have that css class for other core components like com_contact https://github.com/joomla/joomla-cms/blob/4.2-dev/components/com_contact/tmpl/category/default_items.php#L96 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #476 .
Summary of Changes
Remove unused condition, Change button to a link
Testing Instructions
Add several links to one weblink category, add a menuitem of typ Weblink category for this category
Expected result
All links look and behave similar.
Actual result
Links with taget modal are displayed as buttons, so lose underline and focus border on hover, have more padding than other links
Documentation Changes Required