New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handler for 404 not found #105

Draft

jonodrew wants to merge 1 commit into main from error-handlers

Owner

jonodrew commented Jun 25, 2022

This will help in the case of users asking for data that's already been deleted

Owner Author

jonodrew commented Jun 25, 2022

Better late than never, some error handling!

@johnpeart is there a pre-existing 404 error page we can re-use for this?

github-actions bot commented Jun 25, 2022 •

edited

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.13-final-0 -----------

Name	Stmts	Miss	Cover
/app/init.py	22	0	100%
/app/auth/init.py	3	0	100%
/app/auth/routes.py	17	2	88%
/app/classes.py	83	3	96%
/app/config.py	10	1	90%
/app/errors/init.py	3	0	100%
/app/errors/errors.py	5	5	0%
/app/extensions.py	3	0	100%
/app/helpers.py	71	27	62%
/app/main/init.py	7	1	86%
/app/main/routes.py	127	14	89%
/app/tasks/init.py	10	2	80%
/app/tasks/helpers.py	11	4	64%
/app/tasks/tasks.py	34	0	100%
TOTAL	406	59	85%
=======================	35	passed,	45


          Add error handler for 404 not found

0c157cf

This will help in the case of users asking for data that's already been deleted

jonodrew force-pushed the error-handlers branch from 559aada to 0c157cf Compare

June 25, 2022 19:44

Collaborator

johnpeart commented Jun 25, 2022

We have a 404 page on the main website, here:
https://github.com/civilservicelgbt/magenta/blob/main/_layouts/four-oh-four.html

Does that work?

Owner Author

jonodrew commented Jun 25, 2022 via email

That looks great! Then I think it'll just be a matter of copy-pasting it into this repo

On Sat, 25 Jun 2022, 21:25 John Peart, ***@***.***> wrote: We have a 404 page on the main website, here: https://github.com/civilservicelgbt/magenta/blob/main/_layouts/four-oh-four.html Does that work? — Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2ATLUXF4RZMQFLJGCC46DVQ5TM3ANCNFSM5Z2I4HYA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment