Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a user to review the outputs and then task the system to send emails #95

Open
jonodrew opened this issue Jun 20, 2022 · 1 comment

Comments

@jonodrew
Copy link
Owner

Once a user is happy with the proposed outputs, they should be able to tell the system to send the appropriate emails

At the moment the completed outputs are deleted the moment they're downloaded. We can re-use the approach in

@after_this_request
to delay that by some period, maybe ten minutes or so, to give the user time to decide if they want to send the emails or not. We'd probably need some kind of error handling in case the user didn't decide within the ten minutes (or whatever). An MVP might just display something like

You have until {ten minutes from now} to decide!

but maybe less aggressive.

I'm also not sure how to present the option to the user. Another call to action is probably bad practice, so maybe change the download button to a link of some sort...?

After that there'll be a page where users can select their email service - I'll do integrations for Notify and SES to start with I think - and then a page to ask them for their key before passing the task off to Celery for processing. Need to reflect on how we store/process that key while it's being processed

@johnpeart - any thoughts on this?

@johnpeart
Copy link
Collaborator

Could we stick a radio button on what is currently the download page, and give two options:

  1. Download the results
  2. Send notifications

And then route out accordingly?

I think you'd also want some kind of way to see the outputs to test they are correct (though perhaps once we've ironed the kinks out, that's less problematic!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants