Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to link "matching" and "notification" workflow #115

Open
jonodrew opened this issue Aug 23, 2022 · 5 comments
Open

How to link "matching" and "notification" workflow #115

jonodrew opened this issue Aug 23, 2022 · 5 comments
Assignees

Comments

@jonodrew
Copy link
Owner

jonodrew commented Aug 23, 2022

Issue

The matching and notification workflows are currently completely separate.

User needs

  • users can move directly from matching to notifying
  • users can preview their matches
  • users can download their matches without sending notifications

Out of scope

  • users can preview their notification emails
  • users can send follow-up emails
@jonodrew
Copy link
Owner Author

jonodrew commented Sep 1, 2022

This supersedes #95 , although maybe the answer is the same?

@johnpeart
Copy link
Collaborator

I'd add one more user need:

  • users can download their matches without sending notifications

(i.e. people might opt out)

Otherwise, yes, I think the answer is the same.

@jonodrew
Copy link
Owner Author

I think I'll implement previewing short-term as downloading, rather than trying to display it in the interface

@johnpeart
Copy link
Collaborator

johnpeart commented Oct 19, 2022

One more thing has struck me that I thought I'd flag.

You'll recall that the system outputs 2 spreadsheets:

  • mentees and their matches
  • mentors and their matches

Each spreadsheet contains all of the participants, even if that participant has 0 matches.

When we notify people of their matches, they get one of 4 email templates:

  • mentees with a match
  • mentors with a match
  • mentees without a match
  • mentors without a match

You may recall we discussed that I would manually remove the 'no matches' people from the CSV files to create the 4 CSV inputs needed for each of the 4 separate templates. This was a fudge at the time, but only took a few seconds.

If we're automating the emails though, we need to go back and fix that problem; either by:

  • sifting people with no matches and people with 1 or more matches into separate output files (i.e. 4 CSVs not 2), OR
  • having the email system check each item in the two CSV files to then decide what template to send

As ever, sorry for creating you more headaches!

@johnpeart
Copy link
Collaborator

I think I'll implement previewing short-term as downloading, rather than trying to display it in the interface

We will probably need to pop up a warning (something like 'you've got 10 minutes to check your file before it's deleted from the system')?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants