Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two New Options: applyHeightAttributes and applyCenterAttributes #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

madmanlear
Copy link

These updates are very exclusively for email development, specifically more awful clients like Outlook 2013.

  • applyHeightAttributes does exactly what applyWidthAttributes does, but with height!
  • applyCenterAttributes with check to see if margin: auto (or some variant with auto) is applied. If the element is an image, it's wrapped in a <center> element. If it's a table, the attribute align="center" is added.

@jonkemp
Copy link
Owner

jonkemp commented May 30, 2017

@madmanlear are there any open issues which this pull request is addressing?

@madmanlear
Copy link
Author

@jonkemp There aren't, though I'm happy to open some. These are just very common needs for email development that I kept running into.

@jonkemp
Copy link
Owner

jonkemp commented May 30, 2017

@madmanlear if you don't mind, that would be helpful. Even if it's just one.

@madmanlear
Copy link
Author

@jonkemp done!

@jonkemp
Copy link
Owner

jonkemp commented May 30, 2017

@madmanlear thanks. Can you actually split this into two pull requests, one for each feature? Tests would be good as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants