Replace cheerio with jsdom #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jonkemp any updates regarding this will cheerio be replaced or at least upgraded to the latest version? |
Yaminyam
reviewed
Apr 15, 2022
There was a problem hiding this comment.
Why did you change the test output of extract-css?
Does js-beautify add tbody?
Because the current cheerio version has security issues, if it is replaced with jsdom or it takes a long time, it would be good to upgrade even the cheerio version with a hotfix first.
# Conflicts: # lib/setTableAttrs.js # package-lock.json # package.json # packages/extract-css/package-lock.json # packages/list-stylesheets/package-lock.json # packages/list-stylesheets/package.json # packages/list-stylesheets/test/expected/codeblocks-external.html # packages/list-stylesheets/test/expected/codeblocks.html # packages/list-stylesheets/test/expected/ejs.html # packages/list-stylesheets/test/expected/out.html # packages/list-stylesheets/test/main.js # packages/style-data/package-lock.json # packages/style-data/package.json # packages/style-data/test/expected/codeblocks-external.html # packages/style-data/test/expected/codeblocks.html # packages/style-data/test/expected/data-embed/out.html # packages/style-data/test/expected/ejs.html # packages/style-data/test/expected/media-queries/out.html # packages/style-data/test/expected/no-style-tag/out.html # packages/style-data/test/expected/out.html # packages/style-data/test/main.js # test/expected/character-entities.html # test/expected/codeblocks.html # test/expected/ejs.html # test/expected/identical-important.html # test/expected/media.html # test/expected/multiple/two/out.html # test/expected/out.html # test/expected/remote_url.html # test/expected/table-attr.html # test/expected/width-attr.html # test/main.js
# Conflicts: # package-lock.json # packages/extract-css/package-lock.json # packages/list-stylesheets/package-lock.json # packages/style-data/package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.