MRG: docs for hnn-core integration #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jasmainak
reviewed
Mar 22, 2021
installer/mac/README.md
Outdated
| @@ -9,12 +9,12 @@ | |||
| - The command below will run a script to check for existing installations of prerequisites. If a compatible version is installed, it will say which steps can be skipped below. | |||
|
|
|||
| ```bash | |||
| curl -s "https://raw.githubusercontent.com/jonescompneurolab/hnn/master/installer/mac/check-pre.sh" | bash | |||
| curl -s "https://raw.githubusercontent.com/blakecaldwell/hnn/integration_docs/installer/mac/check-pre.sh" | bash | |||
There was a problem hiding this comment.
why is this pointing to your fork?
There was a problem hiding this comment.
Because you all are using this to test HNN GUI and check-pre.sh on master is for the old version. :)
There was a problem hiding this comment.
Also, thanks for the detailed look! You must have been looking closely
blakecaldwell
changed the title
jasmainak
approved these changes
Mar 24, 2021
blakecaldwell
changed the title
blakecaldwell
force-pushed
the
integration_docs
branch
from
9618fec
to
5bcd390
Compare
blakecaldwell
changed the title
|
Merging this is the switchover point for the integration. I'd like @jasmainak to make the switch when agreed upon by the group. Prior to merging a new HNN GUI release should be made. See #283 for instructions on creating release assets that will be downloaded when following these instructions. |
jasmainak
reviewed
Mar 30, 2021
| @@ -16,7 +16,7 @@ sudo yum -y install python34-setuptools | |||
| sudo easy_install-3.4 pip | |||
| pip3 install --upgrade matplotlib --user | |||
| pip3 install --upgrade nlopt scipy --user | |||
| pip3 install hnn-core | |||
| pip3 install https://api.github.com/repos/jonescompneurolab/hnn-core/zipball/master | |||
There was a problem hiding this comment.
we can draft a minor release of hnn-core to go with the release of hnn ...
|
Fixes #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge this once a release has been created for the HNN-integration. Users will be directed to download the new version.