-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$mol_view added #135
base: master
Are you sure you want to change the base?
$mol_view added #135
Conversation
@@ -437,6 +437,20 @@ var d41d8cd98f00b204e9800998ecf8427e_LibraryDetectorTests = { | |||
} | |||
}, | |||
|
|||
'$mol_view': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'$mol_view': { | |
'$mol': { |
Since the documentation for this library refers to itself as $mol
, the name should reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$mol
is the namespace. There are many libraries. $mol_view
(view components base class) is one of them.
icon: 'mol', | ||
url: 'http://mol.js.org/', | ||
test: function(win) { | ||
if (win.$mol_view) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (win.$mol_view) { | |
if (win.$mol_view || win.document.querySelector('$mol_view_root')) { |
Would be preferable to having two, single-condition if
blocks here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 2 simplest conditions are easier to understand than 1 complex condition.
Why not accept it? |
http://mol.js.org