Detect and handle connection lost errors #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi, @e-nastasia. I'm sorry for delay.
Thank you for pointing it out.
Could you check some comments?
| Err(_) => continue, | ||
| Err(e) => match e { | ||
| Error::MaxRetriesExceeded => { | ||
| error!("Reached MaxRetriesExceeded"); |
There was a problem hiding this comment.
Could you use lowercase for error messages?
ref: rust-lang/api-guidelines#79
| break; | ||
| } | ||
| Error::ConnectionClosed => { | ||
| error!("Reached ConnectionClosed"); |
There was a problem hiding this comment.
I think we can't access this error because it isn't returned to the main task.
Are you assuming that this pull request is a first step to fix a connection lost problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @johnmanjiro13!
Thank you for the work you've put into creating this crate! I am happy it exists and I find it very useful.
I am having one issue with it though: when my binary loses connection to fluent, there's no way for me to catch this situation and handle it because the connection errors aren't propagated from the crate.
So I've created this pull request to address the issue: with these changes crate users will be able to get access to the connection lost errors so they can do something about it.