This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Started converting CSS to SASS #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About halfway through this but has felt like a unuseful effort because the SASS made is just as hard to use as the original CSS because of the source CSS itself.
There are so many shared and overwritten styles that it makes converting it to SASS somewhat redundant.
The CSS ideally needs completely rewriting, also implementing more modular styling and less breakpoints.
I've pushed this up anyway in case anyone wants to carry this on but the CSS in my opinion needs a really good thought about moving forward with it if any major future changes to the styles are needed.