This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Move runes section to bottom when viewport is small. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the viewport is small or extra-small, the runes section would split the skill order and build order sections. By moving the runes section to the bottom, we can bring the skill order and build order sections close together. The runes and masteries are grouped as well now too! Layout is the same as before when the viewport is medium or larger.
|
Have you had a chance to look at this? (: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the viewport is small or extra-small, the runes section would split
the skill order and build order sections. By moving the runes section to
the bottom, we can bring the skill order and build order sections close
together. The runes and masteries are grouped as well now too!
Layout is the same as before when the viewport is medium or larger.
http://imgur.com/a/NQR2S shows what the page now looks like on medium+ and small- viewports.