Build correctly on modern GHC and better error message upon common build failure #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Char, CDouble without explicitly importing their data constructors. Import them in the auto-generated code
…s from Foreign.C.Types before using them in FFI declarations
kowey
pushed a commit
to kowey/wxHaskell
that referenced
this pull request
Oct 3, 2017
fix IsStatic tests; add wxc_def.h so that the version number could be…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If system lacks "wx-config" in $PATH, then currently the Setup.hs in wxc will just fail silently, swallowing errors.
I got: "Setup: failed" which is confusing and frustrating.
I added a small patch to log an error about this to make the failure much more self-evident (message about failed invocation of wx-config).
Additionally, wxdirect and wxcore had overly restrictive dependency constraints on time/containers.
Additionally, wxdirect generated FFI declarations that depend on Foreign.C.Types without explicitly importing their data constructors, which is no longer allowed. Similarly, wxcore had such code. Added the necessary imports.