Fix memory leak in nvmpi_enc, also add more cleanup to nvmipi dec/enc #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterAP23
added a commit
to HunterAP23/jetson-ffmpeg
that referenced
this pull request
May 4, 2021
|
@jocover ，I found the same problem,when use nvmpi_enc. I had fixed “nvmpi_encoder_close”，release ctx->packets[index]。 |
There was a problem hiding this comment.
@vietnx Just a thought on this, dpkg is a bad way to get version, much better to pull it from tegra version file in /etc. A lot of distros dont have dpkg, and this will completely break this on them. Also it is really dirty to be running external commands in the background in a lib. Where with a text file, it is open and parse. much faster, and clean. You also dont have to include/wait for extra threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.