Set file modification time according to UTC #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The return type should be `struct_time`
Closed
|
Thanks for this PR. I'm not sure I understand how this interacts with #310 which attempts to utilize location data to determine the proper time zone. Feel free to describe that else I'll try and get to it myself once I have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
date_takenmetadata is UTC, we can use calendar.timegm to update the file modification time according to the local timezone.Currently,
mktimeis used which assumes a local datetime.This is not the case, and because DST flag is always set to 0, the time offset is not even consistent.