New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add critic and tidy #46
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfamiliar with Test::Perl::Critic, coming more from a Code::TidyAll background. Is there a simple way to automatically clean up code (e.g. with tidyall
) that these tests flag?
@@ -37,7 +37,8 @@ | |||
"Test::MinimumVersion::Fast" : "0.04", | |||
"Test::PAUSE::Permissions" : "0.07", | |||
"Test::Pod" : "1.41", | |||
"Test::Spellunker" : "v0.2.7" | |||
"Test::Spellunker" : "v0.2.7", | |||
"Test::Perl::Critic" : "0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add these to the cpanfile, as well?
{$a->time_published <=> $b->time_published } | ||
values( %{ $self->webmentions_by_source } ) | ||
; | ||
my $ret = sort { $a->time_published <=> $b->time_published } values(%{$self->webmentions_by_source}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes this method's behavior? It is supposed to return a list (the output of the call to sort()), not a scalar value.
No description provided.