add custom flag gorm:custom_transaction to bypass default transaction #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxshine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…faultHandler
Make sure these boxes checked before submitting your pull request.
For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.
What did this pull request do?
This PR is to add a setting to enable application developer to control when GORM should do things for them in GORM transactions.
For details, the PR adds a new setting named
gorm:custom_transaction. The application developer could set it before call any GORM API. As DefaultHandler has most CUD callbacks with transaction started automatically, the new logic will checkgorm:custom_transactionfirstly before do transaction things.This feature can help application developer do their things at their demands easily and do not need to do the global setting or develop a customized callback plugin to do this. It is more convenient to use this setting.
Please kindly help review this PR.
Thanks.