docs: improve document about settings #248
Conversation
|
I'm not a native English speaker, so maybe it could be better expressed. |
Ditto :) |
| @@ -105,13 +105,14 @@ Note that when using insecure context StreamSaver will navigate to the download | |||
|
|
|||
| # Configuration | |||
|
|
|||
| By default, `https://jimmywarting.github.io/StreamSaver.js/mitm.html?version=2.0.0` will be used to create the iframe in secure context. But it could be unavailable when using Firefox or an environment where `github.io` can not be accessed, then you need to config a custom `mitm.html` by yourself. | |||
|
|
|||
There was a problem hiding this comment.
I do not believe it is a specific Firefox issue?
I think it's more about 3th party cookie restrictions
you see, if you disable 3th party cookies in chrome or in safari then jimmywarting.github.io/StreamSaver.js/mitm.html won't work either...
It's should say something like:
StreamSaver uses a 3th party service to install a service worker on an external domain (hidden in a iframe). This can sometimes be restricted by disabling 3th party cookies in your browser. To get around this issue it's best to self-host the service worker and replace
streamSaver.mitmto your own domain.
Toughts?
It may also be a problem in incognito mode where things are more private
There was a problem hiding this comment.
It seems #242 is not mentioned in the new sentence?
There was a problem hiding this comment.
unrelated, but... My https://github.com/jimmywarting/native-file-system-adapter works a bit differently... same concept doe... but it communicates with service workers directly without a mitm or any hidden iframes or will use the native file system access window.showSaveFilePicker
you are more required to self host the service worker yourself
There was a problem hiding this comment.
There was a problem hiding this comment.
I mean my words or an environment where `github.io` can not be accessed
There was a problem hiding this comment.
a setting for communicating with service worker directly instead of via a iframe could also be preferred.
I didn't know we can skip mimt even. 😂
There was a problem hiding this comment.
will use the native file system access window.showSaveFilePicker
Yeah, I'm also doing this myself.
close #242
close #247