Varnish 4.0 support #10
Conversation
|
would be nice to have this merged, anything keeping it back? |
|
@prometheanfire this changes the build process, and I haven't had the cycles yet to verify it still works as expected against 3.x. |
|
I'm fairly sure the Varnish 4 VMOD API is backwards incompatible with 3. |
|
I've made my own conversion (#11) before checking existing PRs... Both are very close. I'll try to just submit some stuff to this original PR. @jib @pushrax I confirm it won't work on 3x. Some guys tried to make a VMOD compatible with both versions but the code becomes ridiculously complex and it requires As most VMODs are made of simple code and don't receive hundreds commits per day, it seems easyer to keep a branch for each 3.x and 4.x (that's what Varnish made for their own VMODs) and backport every change between them (most commits can be directly merged on both branches, as soon as they don't touch some v3 or v4 specific stuff. |
pushrax
force-pushed
the
varnish-4.0
branch
from
8297d7c
to
4e5b608
Compare
|
What is the state on this? |
Tells the user in more user-friendly way if we could not find varnish.m4. make dist should work now.
Import automake changes from vmod-example.
|
👍 |
upgrade to varnish 4.1 and remove VCL_INT to int conversion warnings
Tested on varnish-4.0.1 rev. 4354e5e, Linux 3.2.0-4-amd64.
I'm new to Varnish, so let me know if I missed something! I have libvmod-timers mostly done as well (and in production), but need to find some time to dig further into the structs to figure out some inconsistent values I'm seeing.
Side note: the official VMODs all seem to use the master branch for Varnish 4, and a separate branch for Varnish 3, but then set the default branch to the Varnish 3 one. Seems like a reasonable thing to do.