Pod formatting and test failure fixes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larger block sizes result in a negative length on 32 bit Perls, which made the tests fail.
There apparently are cases where the text in the exception is localised in the language of the system the tests are running on, i.e. not necessarily English, in which case this test was failing.
The lines in this paragraph were indented which tended to make it being rendered as code block which looked bad in both text based POD viewers as well as when this was rendered as HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #38 (comment) this should fix the test failures on 32 bit Perls that got introduced in #38.
In addition to the above, this should also fix test failures in
90_symlink.t(for example this one) that seem to have been caused by localized error messages. I wasn't able to reproduce that though, even though my machines usually actually use a non-English locale. I'm also not sure this is the best way to fix this.When I looked at the POD I added in #38 on meta::cpan, I noticed that the preceding section ("Tuning the way RESOLVE_SYMLINK will works") was looking a bit weird, so I also added a commit to improve that. As I didn't fully understand the content of the section, I didn't touch the wording and only tried to improve the formatting.