-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reference field properties to be preserved after expanding the values. #252
Open
idimopoulos
wants to merge
17
commits into
jhedstrom:master
Choose a base branch
from
idimopoulos:secondary_reference_properties
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow reference field properties to be preserved after expanding the values. #252
idimopoulos
wants to merge
17
commits into
jhedstrom:master
from
idimopoulos:secondary_reference_properties
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing is a bit trickier because the reference handler uses the container but Drupal is not a dependency in composer and composer requires symfony console which conflicts.
|
claudiu-cristea
approved these changes
Oct 26, 2022
Fixes #254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
I am having a file field which has the display field enabled. That means that when we create a new entity, we want to also be able to set the 'display' property of the field.
Now, we are using behat but we have arranged our code to reach the proper structure of the field in the
\Drupal\DrupalExtension\Context\RawDrupalContext::nodeCreate
where the values reach asOne of the values is a multi column value and the rest are simple label references. Of course we take care of creating the files before hand.
However, when reaching
\Drupal\Driver\Fields\Drupal8\EntityReferenceHandler::expand
the entity query fails with the following error:because it simply passes the value in the query.
Proposal
From what I see from the PHPDocBlocks, the
$values
array is supposed to be a field value array and the return is supposed to be a field value array as supposed to be retrieved by the field storage.My assumption as such, is that we need to preserve the columns when querying the values and returning them. Thus, I propose to identify the
target_id
property - or any property used for the reference, and if present, extract the label for the entity instead of blindly passing the$value
in the query.Please, note that this means that we maintain the philosophy of the current functionality, that since the user passes a label as a value to get the entity, if they would like to use a more complex value, then the label would be passed in the reference property key. For example, if we have a reference to a node, the complex array would be
and not
At least that is how I see it.
Remaining tasks
Tests?