Issue 200 fix issue with creation of date only fields #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedstrom
reviewed
Nov 6, 2018
| $date = new DateTime($value, $siteTimezone); | ||
| $date->setTimezone($storageTimezone); | ||
| $values[$key] = $date->format('Y-m-d\TH:i:s'); | ||
| if (DateTime::createFromFormat('Y-m-d', $value) !== FALSE) { |
There was a problem hiding this comment.
Yes it returns FALSE when value is of datetime type e.g. 2017-04-02T05:00:00.
|
The reason the old code uses that format is that even for date-only fields, the actual storage has the entire date and time string. |
|
Yes this is what my understanding is. Ideally date-only fields should have been created with and without the timestamp but not happening with timestamp for me. Perhaps there is a change in Drupal core 8.6.x the way it handles the Date. |
|
Running into the same issue, I have a date only field but I can set the value: field_date remains empty. This patch fixed the issue. |
MPParsley
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 200 (#200), an issue with the creation of date only fields