Base k disjoint shortest paths improvement #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsichi
changed the title
jsichi
reviewed
Aug 26, 2018
| // connected component of the start vertex, we are inducing the working graph from | ||
| // the connected component. | ||
| Graph<V, E> connectedComponentGraph = new AsSubgraph<>(this.originalGraph, | ||
| new ConnectivityInspector<>(this.originalGraph).connectedSetOf(startVertex)); |
There was a problem hiding this comment.
Calling ConnectivityInspector is correct and simple, but it duplicates the work performed by the first invocation of calculateShortestPath (which can run against the original). Can you think of a way to avoid that without too much extra complexity?
Also, the common case where the graph is connected is easy to detect (connected component size == full graph size); so in that case, we should avoid the AsSubgraph overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #648. Now inducing the working graph using the connected component of the source.