Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing License Headers #1215

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

syoon2
Copy link

@syoon2 syoon2 commented Apr 11, 2024

Regarding the question of adding the license headers to the -info.java files, yes, that would be a good as a separate PR. If you do that, be sure to remove the exclusions in etc/jgrapht_checks.xml and etc/checkstyle_suppressions.xml.

Originally posted by @jsichi in #1213 (comment)

This PR adds the missing license headers to the module-info.java and package-info.java files and updates the Checkstyle rule accordingly.

The added license headers respect (or at least try to respect) the original authorships of the files, i.e., the year that the file was added and the original author's name are included, not my name and 2024.


@syoon2
Copy link
Author

syoon2 commented Apr 11, 2024

Original author(s) of the module-info.java files

@syoon2 syoon2 mentioned this pull request Apr 11, 2024
7 tasks
The original header contained the year added,
but not the current year. This commit fixes it.
@syoon2
Copy link
Author

syoon2 commented Apr 12, 2024

Original author(s) of the package-info files and their respective commits / PRs

@syoon2 syoon2 marked this pull request as ready for review April 12, 2024 02:31
@jsichi
Copy link
Member

jsichi commented Apr 14, 2024

I think in etc/jgrapht_checks.xml we need to remove the BeforeExecutionExclusionFileFilter so that module-info.java gets checked as well.

@syoon2
Copy link
Author

syoon2 commented Apr 15, 2024

I think in etc/jgrapht_checks.xml we need to remove the BeforeExecutionExclusionFileFilter so that module-info.java gets checked as well.

Something that I missed. Thanks for catching 😄

@syoon2 syoon2 mentioned this pull request Apr 15, 2024
7 tasks
@syoon2
Copy link
Author

syoon2 commented Apr 15, 2024

Turns out, we cannot enable Checkstyle running on module-info.java files due to an upstream issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants