Increase performance of creating of subgroup #1108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An idea of this optimisation is adding a special case when subgroup has vertex set which is smaller than base's edge set. For example when you have huge graph which very each vertex has a few connection, this optimisation allows to not wols across all edges, just across all desired vertexes.
catap
added a commit
to DataDome/RegexStaticAnalysis
that referenced
this pull request
Sep 30, 2021
The reason to switch is to use jgrapht/jgrapht#1108
catap
added a commit
to DataDome/RegexStaticAnalysis
that referenced
this pull request
Sep 30, 2021
The reason to switch is to use jgrapht/jgrapht#1108
|
@jkinable any chance to review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea of this optimisation is adding a special case when subgroup has vertex set which is smaller than base's edge set.
For example when you have huge graph which very each vertex has a few connection, this optimisation allows to not walk across all edges, just across all desired vertexes.
HISTORY.mdorCONTRIBUTORS.md