Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token to output if available #148

Closed
wants to merge 1 commit into from

Conversation

faubion-hbo
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Description

allows other actions in a workflow to get at the token used to auth the CLI which is especially useful for OIDC auth

Solved problem

there isn't a way to get the token to use in other applications from the jf commands themselves, and the config is encrypted

Questions

  1. what description would be appropriate for the output? i wasn't sure how to word all the cases where a token would/would not be returned.
  2. what test can be added for this?

Copy link

github-actions bot commented May 9, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@@ -15,6 +15,9 @@ inputs:
oidc-audience:
description: "By default, this is the URL of the GitHub repository owner, such as the organization that owns the repository."
required: false
outputs:
token:
description: ""
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please suggest an appropriate text here with:

```suggestion
        description: "a better description..."
```

@faubion-hbo faubion-hbo closed this by deleting the head repository May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant