Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the dependencies in plaintext tree in commander.js #35

Merged
merged 6 commits into from
May 19, 2024

Conversation

younthu
Copy link
Contributor

@younthu younthu commented Apr 26, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

nuget-deps-tree [path to sln file], it will print dependencies in json.

or

nuget-deps-tree --text [path to sln file], it will print dependencies in plain text as below:

plainTextFormat

Copy link

github-actions bot commented Apr 26, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@younthu
Copy link
Contributor Author

younthu commented Apr 26, 2024

I have read the CLA Document and I hereby sign the CLA

@younthu
Copy link
Contributor Author

younthu commented Apr 29, 2024

Anyone can help to review this please?

@RobiNino RobiNino self-requested a review May 1, 2024 14:47
Copy link
Contributor

@RobiNino RobiNino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!
I'd appreciate if you could add "bin/**/*.ts" to the format script in package.json, then run npm run format.
Thanks!

bin/command.ts Outdated Show resolved Hide resolved
younthu and others added 2 commits May 17, 2024 23:19
Co-authored-by: Robi Nino <robin@jfrog.com>
@younthu
Copy link
Contributor Author

younthu commented May 17, 2024

Hi @RobiNino , thanks for your review and comments! i updated it. could you help to review it again? thanks.

@younthu younthu requested a review from RobiNino May 18, 2024 03:13
@RobiNino RobiNino merged commit 6e8c60c into jfrog:master May 19, 2024
1 check passed
@RobiNino
Copy link
Contributor

Thanks again @younthu !
Version 0.4.0 is now released with your new feature.

@younthu
Copy link
Contributor Author

younthu commented May 20, 2024

Thank you very much! @RobiNino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants