New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List.length .isEmpty checks on Dict, Set and Array.toList (and more) #293
Merged
jfmengels
merged 8 commits into
jfmengels:main
from
morteako:list-length-and-isempty-checks
Mar 7, 2024
Merged
List.length .isEmpty checks on Dict, Set and Array.toList (and more) #293
jfmengels
merged 8 commits into
jfmengels:main
from
morteako:list-length-and-isempty-checks
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morteako
force-pushed
the
list-length-and-isempty-checks
branch
from
March 6, 2024 19:22
58d57a9
to
54a4361
Compare
morteako
force-pushed
the
list-length-and-isempty-checks
branch
from
March 6, 2024 19:40
54a4361
to
57e6dc7
Compare
lue-bird
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💙
If you want, add this to CHANGELOG.md under unreleased: The rule now simplifies:
- `Array.length (Array.fromList list)` to `List.length list`
- `List.length (Array.toList array)` to `Array.length array` (same for `Array.toIndexedList`)
- `List.isEmpty (Array.toList array)` to `Array.isEmpty array` (same for `Array.toIndexedList`)
- `List.length (Set.toList set)` to `Set.size set`
- `List.isEmpty (Set.toList set)` to `Set.isEmpty set`
- `List.length (Dict.toList dict)` to `Dict.size dict` (same for `Dict.values` and `Dict.keys`)
- `List.isEmpty (Dict.toList dict)` to `ict.isEmpty dict` (same for `Dict.values` and `Dict.keys`) |
jfmengels
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you @morteako 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies uneccessary convertions from a Collection into List before a List.length / List.size, when you could just do
Collection.size or Collection.isEmpty
Mentioned before in comment here: #290 (comment)
Also adds one simplification for
Array.length (Array.fromList list)
Simplifications:
Array
Set
Dict