added option to symlink (ln -s)
#48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works wonderfully. Instead of cloning the entire dataset now, I just have links to the original image, which saves so much time and memory. I am very much in favor of merging this into the package. |
|
hi, this option would be amazing, will it be integrated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #31. The advantage of having symlinks (
ln -s) is that we can just reference the dataset stored at some other place and create a folder structure at any/multiple desired locations as required by some codebases. Deleting symlinks doesn't delete the original dataset.The changes have been made to support backward compatibility of
move=Trueandmove=Falsealong with the addition ofmove='symlink'. All tests have successfully passed.