Added a way to sort torrent peers columns #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noé Fleury <23384755+noefleury@users.noreply.github.com>
noefleury
force-pushed
the
feature/sort-torrent-peers
branch
from
ff9f62d
to
2a5d3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've found sad that we didn't have the ability to sort the "Torrent Peers" table.
More precisely, currently it seems to be sorted automatically on the the backend side by IPs.
Personally, I'm always curious to see which peers are giving me the best download speeds and to where I'm uploading the faster.
Screenshots
Types of changes
So I've implemented a logic to sort columns on a click and I've followed the project logic to don't diverge too much from the main idea.
It is possible to sort by any columns and in any direction.
Note that the sort can handle IPv4/v6 too.