Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian packaging [meta] #1945

Open
rzr opened this issue Jul 23, 2020 · 11 comments
Open

debian packaging [meta] #1945

rzr opened this issue Jul 23, 2020 · 11 comments

Comments

@rzr
Copy link
Contributor

rzr commented Jul 23, 2020

Hi,
As debian maintainer of iotjs package,

Let me forward a bug that affect iotjs-1.0 and current master:

https://bugs.debian.org/957364

I am still committed to fix issues to keep this package in debian,
Please review linked PR:

https://github.com/jerryscript-project/iotjs/pulls/rzr

I need to be quick if not it will be removed in august.

Kind Regards

rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 23, 2020
This change is useful for debian packaging

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Update: 2020-07-24
@rzr
Copy link
Contributor Author

rzr commented Jul 24, 2020

Please merge this one ASAP:

#1944

Then I can patch downstream using gbp pq.

Regards

rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
Note: This is not the latest version (v2.3.0),
but this intermediary version solve building issue on ubuntu-20.04
while olders ones didn't (v2.1.0, v2.0).

Observed issue with gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0:

    inlined from ‘jerry_init’ at .../jerry/jerry-core/api/jerry.c:175:3:
    /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:10: error: \
    ‘__builtin_memset’ offset [69, 4352] from the object at \
    ‘jerry_global_context’ \

This will help to keep iotjs in debian repo

Change-Id: Idd5f87844396b92b89674c11caa0203d7a30eb28
Forwarded: jerryscript-project#1944
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/upstream/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Last-Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to rzr/iotjs that referenced this issue Jul 24, 2020
Observed issue using cmake:

    CMake Error at CMakeLists.txt:136 (string):
    string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1943
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This will help for debian upgrade

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: https://github.com/jerryscript-project/iotjs/pull/rzr
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This will help for debian upgrade

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1947
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: https://github.com/jerryscript-project/iotjs/pull/rzr
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
Reintroduce this feature after 99ec371

It was useful for debian packaging (iotjs-dev),
to match quality standards.

Email has been updated for community support

Relate-to: https://packages.qa.debian.org/i/iotjs.html
Fowarded: jerryscript-project#1896
Relate-to: jerryscript-project#1145
Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b
Bug: jerryscript-project#1945
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
Observed issue using cmake:

    CMake Error at CMakeLists.txt:136 (string):
    string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1943
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This will help for debian upgrade

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1947
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 24, 2020
This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 25, 2020
This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

Change-Id: Id4509a97f05eb77a40145b7aa50360b92f806fdf
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 25, 2020
Upstream fixed this in jerryscript submodule
but iotjs is not supporting it yet.

Relate-to: jerryscript-project#1945
Signed-off-by: Philippe Coval <rzr@users.sf.net>
Change-Id: I4d84de2e826cc259d0f1cff75c797ec70cb1db65
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 25, 2020
This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
Last-Update: 2020-07-25
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

Change-Id: I48bf135d7a3af6e64859252078931ff3388a87a6
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 25, 2020
This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

Change-Id: Ic0db03346959f2760439aac84a0cbc166fc54d0d
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 27, 2020
This will be useful for next debian release shipping python3

Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 27, 2020
This will be useful for next debian release shipping python3

Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 28, 2020
This will be useful for next debian release shipping python3

Version can be specified as cmake option using:

    CMAKE_OPTIONS=-DPYTHON="python3"

Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
Relate-to: https://travis-ci.org/github/TizenTeam/iotjs/builds/712336077
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Jul 29, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to rzr/iotjs that referenced this issue Jul 29, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
akosthekiss pushed a commit that referenced this issue Jul 31, 2020
This will be useful for next debian release shipping python3

Version can be specified as cmake option using:

    CMAKE_OPTIONS=-DPYTHON="python3"

Bug: #1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: #1946
Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
Relate-to: https://travis-ci.org/github/TizenTeam/iotjs/builds/712336077
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
akosthekiss pushed a commit that referenced this issue Jul 31, 2020
Observed issue using cmake:

    CMake Error at CMakeLists.txt:136 (string):
    string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: #1943
Bug: #1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
akosthekiss pushed a commit that referenced this issue Jul 31, 2020
This will help for debian upgrade

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: #1947
Bug: #1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
@rzr
Copy link
Contributor Author

rzr commented Aug 4, 2020

FYI: The status of the iotjs source package
in Debian's testing distribution has changed.

Previous version: 1.0-1
Current version: 1.0-2

https://tracker.debian.org/pkg/iotjs

It's still outdated, I'll resume works once jerry 2.x is merged.

@galpeter
Copy link
Contributor

galpeter commented Aug 4, 2020

AFAIK the Jerry 2.3+ version was merged yesterday.

rzr added a commit to TizenTeam/iotjs that referenced this issue Aug 6, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Aug 6, 2020
This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Aug 6, 2020
Disable error on warning in cmake files

Upstream FTBFS this in jerryscript submodule
but iotjs is not supporting it yet.

Relate-to: jerryscript-project#1945
Signed-off-by: Philippe Coval <rzr@users.sf.net>
Change-Id: I4d84de2e826cc259d0f1cff75c797ec70cb1db65

Revert "debian/rules: Relax compiler to continue on warnings (Closes: #957364)"

This reverts commit 9264ca24a936edef4d1c02933a3fd97e6a469db2.
@rzr
Copy link
Contributor Author

rzr commented Oct 15, 2020

I am consider to release a snapshot package to fix CVE:

https://security-tracker.debian.org/tracker/source-package/iotjs

BTW please review pending PR starting with:

#1923

rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 15, 2020
Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896).

Also remove headers, lib when installing executable.

This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Last-Update: 2020-10-15
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 15, 2020
Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896).

Also remove headers, lib when installing executable.

This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Last-Update: 2020-10-15
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 15, 2020
installing the static lib will also install headers (Fixes: jerryscript-project#1896).

This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Relate-to: jerryscript-project#1896
Last-Update: 2020-10-15
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 15, 2020
installing the static lib will also install headers (Fixes: jerryscript-project#1896).

This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Relate-to: jerryscript-project#1896
Last-Update: 2020-10-15
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 15, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-07-24
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 16, 2020
installing the static lib will also install headers (Fixes: jerryscript-project#1896).

This is useful for debian's iotjs-dev package

The extra archive rule is needed to prevent this error:

   install TARGETS given no ARCHIVE DESTINATION for static library target

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: jerryscript-project#1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Relate-to: jerryscript-project#1896
Last-Update: 2020-10-16
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 16, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-10-16
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 16, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Update: 2020-10-16
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue Oct 16, 2020
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Gbp-Pq: Name 0001-iotjs-Install-binaries-to-system-1134.patch
Update: 2020-10-16
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
@rzr
Copy link
Contributor Author

rzr commented Oct 21, 2020

Update:
https://tracker.debian.org/news/1184873/accepted-iotjs-10715-1-source-into-unstable/

Once related changes are merged I am considering to add generic profiles for next snapshot release

@rzr
Copy link
Contributor Author

rzr commented Oct 26, 2020

Update:
https://tracker.debian.org/news/1186717/iotjs-10715-1-migrated-to-testing/

It would help to tag a new release once those pending patches are merged:

https://github.com/jerryscript-project/iotjs/pulls

@rzr rzr changed the title FTBFS on debian's sid with gcc-4.10 [meta] debian packaging [meta] Dec 21, 2020
@rzr
Copy link
Contributor Author

rzr commented Dec 21, 2020

Is a new @JerryScript release planned soon?

one that ship:

jerryscript-project/jerryscript@edab196

to fix

https://bugs.debian.org/977736

Latest is 6 months old

https://github.com/jerryscript-project/jerryscript/tags

Ideally it should be then also updated in iotjs, then I will refresh this PR

#1953

@akosthekiss
Copy link
Member

  • JerryScript release: summon @dbatyai @rerobika @ossy-szeged
  • Debian bug: IMNSHO the bug report is invalid as iotjs does not build or use the command line tool of jerryscript, thus it cannot be affected by its vulnerability

LaszloLango pushed a commit that referenced this issue May 12, 2021
Installing the static lib will also install headers (Fixes: #1896).

This is useful for debian's iotjs-dev package. The extra archive rule is needed to prevent this error:
   install TARGETS given no ARCHIVE DESTINATION for static library target

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4
Forwarded: #1948
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master
Bug: #1945
Bug-Debian: https://bugs.debian.org/957364
Relate-to: #1896
Last-Update: 2020-10-16

IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr added a commit to TizenTeam/iotjs that referenced this issue May 12, 2021
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: jerryscript-project#1923
Bug: jerryscript-project#1945
Relate-to: jerryscript-project#1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Gbp-Pq: Name 0001-iotjs-Install-binaries-to-system-1134.patch
Update: 2020-10-16
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
@rzr
Copy link
Contributor Author

rzr commented Jun 16, 2021

Please can anyone ping @akosthekiss to merge:

#1923

It will help to fix:

https://security-tracker.debian.org/tracker/source-package/iotjs

akosthekiss pushed a commit that referenced this issue Jun 18, 2021
Install directory is prefixed by destdir to install in staging directory.

This change is useful for debian packaging.

Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property

This was introduced first in #1134 and then dropped in #1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Email has been updated for community support.

Forwarded: #1923
Bug: #1945
Relate-to: #1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master
Bug-Debian: https://bugs.debian.org/957364
Gbp-Pq: Name 0001-iotjs-Install-binaries-to-system-1134.patch
Update: 2020-10-16
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
@rzr
Copy link
Contributor Author

rzr commented Jul 1, 2023

For the record iotjs is no more part of debian stable branch:

https://tracker.debian.org/pkg/iotjs

[2022-08-13] Removed 1.0+715-1 from unstable (Debian FTP Masters)
[2022-06-17] iotjs REMOVED from testing (Debian testing watch)
[2020-10-26] iotjs 1.0+715-1 MIGRATED to testing (Debian testing watch)
[2020-10-26] iotjs 1.0+715-1 MIGRATED to testing (Debian testing watch)
[2020-10-20] Accepted iotjs 1.0+715-1 (source) into unstable (Philippe Coval) (signed by: Xavier Guimard)
[2020-08-04] iotjs 1.0-2 MIGRATED to testing (Debian testing watch)
[2020-07-29] Accepted iotjs 1.0-2 (source) into unstable (Philippe Coval) (signed by: Bart Martens)
[2018-03-25] iotjs 1.0-1 MIGRATED to testing (Debian testing watch)

Is this project still maintained ? if not may I suggest to transfer it to @abandonware org for community maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants