Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline support #25

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Pipeline support #25

wants to merge 6 commits into from

Conversation

mazimkhan
Copy link

Support for working with pipeline jobs.

@kinow
Copy link
Member

kinow commented Nov 4, 2016

Really great stuff @mazimkhan

I believe we are ready to merge it once I can confirm

i) the code from that testlink pull request has been released
ii) 1.9.15 is compatible with the Java API (it was broken the last I tried some weeks ago)
iii ) we have merged and released testlink-java-api

@@ -3,6 +3,7 @@ Test\ Project\ Name=Nome do Projeto de Testes
Test\ Plan\ Name=Nome do Plano de Testes
Platform\ Name=Nome da Plataforma
Build\ Name=Nome do Build
Build\ Custom\ Fields\ Values=Construir valores personalizados Campos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd probably be something like "Campos customizados do Build" (Build as a noun rather than the verb construir). Ditto for Spanish. Will fix after merging.

@@ -147,7 +152,7 @@ public ExecutionStatus getExecutionStatus() {
/**
* Calculates the new value of this wrapped test case execution status,
* given a number of custom fields.
* @param numberOfCustomFields
* @param keyCustomFieldName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!!! :D

@@ -270,7 +270,7 @@
<dependency>
<groupId>br.eti.kinoshita</groupId>
<artifactId>testlink-java-api</artifactId>
<version>1.9.14-0</version>
<version>1.9.14-1-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for using 1.9.14-1-SNAPSHOT? Which version of TestLink did you test your code against, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind the reason for using the snapshot. Probably you were using your local version with the buildCustomFields.

@@ -59,6 +59,10 @@
*/
protected String buildName;
/**
* The Build custom fields.
*/
protected String buildCustomFields;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we merge that other pull request from testlink-java-api, we can merge this PR too.

@kinow
Copy link
Member

kinow commented Feb 7, 2019

I think there was an old review in GitHub, so I just pressed "submit review". Some conflicting files too.... sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants