Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default parameters value resolution. #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iBavtovich
Copy link

Not all custom parameter definitions can be inherited from StringParameterDefinition, but have default String value.
For example ExtendedChoiceParameter:

https://github.com/jenkinsci/extended-choice-parameter-plugin/blob/master/src/main/java/com/cwctravel/hudson/plugins/extended_choice_parameter/ExtendedChoiceParameterDefinition.java

It cannot inherit from StringParameterDefinition, since the method createValue(StaplerRequest req) is final in SimpleParameterDefinition.class

This commit fix default parameters value resolution and makes it dependent on default ParameterValue instead of ParameterDefinition.

Not all custom parameter definitions can be inherited from StringParameterDefinition, but have default String value. This commit fix it and makes resolution dependent to default ParameterValue instead of ParameterDefinition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants