Run setIndex when revisionState==null

[haiyanghaiyang]

The setIndex is not called when open existing job's
manifest information. At that time, revisionState==null,
and the manifest cannot be fetched. The repo manifest
information is blank on web.

The fix just calls setIndex when revisionState==null
before get manifest.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[abioteau]

@francoisferrand This PR looks great, could you merge it? 👍

[francoisferrand]

This looks fishy IMO. The index is expected to be set via the setIndex method : so if setIndex is not called, it actually means the index value was not set. Thus this PR will simply revert to getting the "first" (index=0) manifest/branch/...

Looking quickly at the code, maybe we are just missing a @DataBoundSetter annotation on the setIndex method : which would ensure that revisionState is updated as expected.

[francoisferrand]

if revisionState is null, then it means index was not set (so null) : and this will just load the "first" manifest/banch/...

I think we need to get to bottom of this, i.e. understand why the index was not set properly via setIndex() (missing @databoundsetter annotation maybe?) or why the revisionstate was not properly loaded at that time (timing between calls to setIndex and onLoad/onAttached ?)

[haiyanghaiyang]

If you start a new build, then setIndex is called. However, when you open an existing job, and want to review saved manifest inside, the setIndex is not called. Then we'll get empty manifest information, i.e. blank content in UI.

[TheStrix]

Yep, as @haiyanghaiyang above described, it's called on checkout() in RepoScm and index is set that first time, but when we queue some other build and review back the manifest for some build it returns "" for getManifest() since index is not set in ManifestAction (revisionState is null).

[francoisferrand]

I understand (and fully accept) that setIndex() is not called. However, my understand is that this PR will not fix the whole issue : it will just automatically load the first index, as if setIndex(0) was called, and thus only deal with the case when there is a single manifest (which is indeed the most common).

A better fix would be to make sur the missing call to setIndex() happens when de-serializing ManifestAction objects, to that the correct manifest will be loaded/shown.

[abioteau]

Issue solved by #82