Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP JENKINS-57427 support warnings-ng plugin #221

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyrille-leclerc
Copy link
Contributor

No description provided.

@@ -63,7 +63,7 @@
workflow-step-api or workflow-api-->
<junit-plugin.version>1.26.1</junit-plugin.version>
<asm.version>5.2</asm.version>
<workflow-support-plugin.version>2.22</workflow-support-plugin.version>
<workflow-support-plugin.version>3.2</workflow-support-plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can switch to BOM


xmlOutputDirectory = XmlUtils.getPathInWorkspace(xmlOutputDirectory, workspace);

String spotBugsResultsFile = xmlOutputDirectory + "/spotbugsXml.xml";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only supports SpotBugs so far, maybe better to reflect that in the PR title.

@aheritier aheritier added the wip label Aug 8, 2020
@aheritier aheritier marked this pull request as draft August 8, 2020 13:19
@aheritier aheritier self-assigned this Aug 8, 2020
@aheritier aheritier removed their assignment Aug 30, 2020
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also delete the findbugs plugin dep.

CC @bguerin @uhafner

@bguerin
Copy link
Contributor

bguerin commented Sep 12, 2022

This should also delete the findbugs plugin dep.

Hello @jglick Yes I know. I also really want to do this integration and to remove deprecated dependencies. It is on my top level TODO list. For now, I only do bug fixing to discover the plugin internals, and next then I will work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants