-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update permissions based on changes made in matrix auth plugin 3.0 #1249
base: master
Are you sure you want to change the base?
Conversation
joshiparth1000
commented
Mar 25, 2022
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
@joshiparth1000 This looks interesting, I would need exactly that change. Did you see the build errors in testing, would you be able to handle them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are (trivial) CodeNarc violations causing the build to fail.
Why is this PR not in draft state when FolderSpec
, JobAuthorizationContextSpec
, and JobSpec
are consistently failing?
What would happen if someone attempted to use Job DSL with the changes in this PR and Matrix Authorization Strategy 2.6.11?
it seems like this change is now either required, or about to be for configuring a Jenkins without getting ambiguous permissions warnings. |
Hi I'm not able to configure my job with new dis-ambiguous authorization format introduce in matrix auth plugin 3+.
I got the following error when I'm trying to process the new auth perms with Job DSL plugin.
I suppose this PR was aiming to fix this configuration change. Any chance to resume the progress on this PR? Thanks |
This is continued in #1415 |