Add option to remove original exec file #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build parameter that would trigger the removal of the original exec file after it has been copied to the build job directory. The use-case being that an exec file that has been fetched from a jacoco-agent can be quite huge, and would also only be valid for when the job has finished. Being that a copy exists in the build directory already. Added test in JacocoPublisherTest::testGetterSetter, also added a missing test for setBuildOverBuild/isBuildOverBuild.
mgor
force-pushed
the
remove-exec-after-build
branch
from
03190f8
to
f1ce544
Compare
|
To be honest I am not sure we should add such a feature to this plugin itself as it would further add to the many options that are available and sometimes confuse users and is a use-case that is very rarely needed as far as I see. Also this can easily be done by a simple additional build-step, e.g. a shell command, or? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build parameter that would trigger the removal of the
original exec file after it has been copied to the build
job directory. Default setting being false, hence not
backward incompatible in regards of behavior.
The use-case being that an exec file that has been fetched
from a jacoco-agent can be quite huge, and would also only
be valid until the job has finished. Being that a copy
exists in the build directory already it seems unnecessary
to keep the original in the workspace.
Added test in JacocoPublisherTest::testGetterSetter, also
added a missing test for setBuildOverBuild/isBuildOverBuild.
A bunch of unnecessary whitespaces was also removed...