Fix rec catch exception #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done this to resolve spotbugs fix
MarkEWaite
reviewed
Oct 29, 2022
Comment on lines
+38
to
+41
| }catch(RuntimeException e){ | ||
| throw new RuntimeException(e); | ||
| } | ||
| catch (Exception e) { |
There was a problem hiding this comment.
I don't see the benefit of this change in reducing the likelihood of issues. Can you explain further or point me to a location where I can read more about the benefit of this change?
There was a problem hiding this comment.
As spotbug spots this issue of REC_CATCH_EXCEPTION so rather than ignoring that bug in excludes file i think it's a good approach to make a code change to solve that issue
There was a problem hiding this comment.
Adding this will catch the runtime exceptions and make the issue solve for reference you can check Alluxio/alluxio#10459
There was a problem hiding this comment.
@MarkEWaite doesn't it seems good to have this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done the code fix to overcome the spot bug error for REC_CATCH_EXCEPTION
This exception is thrown when we use catch(Exception e) to catch all types of exceptions at once, it could mask actual programming problems, so spotbugs ask you to catch the specific exception so that run-time exceptions can be thrown which indicate programming problems.