[JENKINS-32898] Fix Disable Strict Forbidden File Verification option #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Strict Forbidden File Verification option is disabled, job can still be triggered if file paths are mixed, i.e. there are some files that match forbidden file paths, and some that only match included file paths. However, when ALL files match forbidden file paths, job should not be triggered. This patch ensures this by checking whether all files match forbidden file paths if Strict Forbidden File Verification Option is disabled.
kars7e
force-pushed
the
fix-forbidden-path
branch
from
eb27d02
to
5976fc8
Compare
rsandell
requested changes
Jul 3, 2017
| if (foundInterestingForbidden) { | ||
| // we have a forbidden file and a wanted file path. | ||
| } else { | ||
| for (FilePath ffp : forbiddenFilePaths) { |
There was a problem hiding this comment.
probably needs a null check as you've done in isForbiddenFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Strict Forbidden File Verification option is disabled, job can
still be triggered if file paths are mixed, i.e. there are some files
that match forbidden file paths, and some that only match included file
paths. However, when ALL files match forbidden file paths, job should
not be triggered.
This patch ensures this by checking whether all files match forbidden
file paths if Strict Forbidden File Verification Option is disabled.
This change is