Logged info whenever falling back to on-demand instance

[arunmastermind]

Logged info whenever falling back to on-demand instance as this is very useful to track the logs

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[arunmastermind]

Logged info whenever falling back to on-demand instance as i found this missing and there is no way to find out the reason for on demand instances.
we must be very focused on providing the logs as the end user will always judge the product as per these features.

[res0nance]

This actually creates a spot instance

[arunmastermind]

Not exactly,
this check for "spotConfig.useBidPrice" is checking if the bid price is available or not and if not then its provisioning OnDemand (provisionOndemand).
here again, the end user is not getting any information or reason about getting OnDemand Instance rather than a spot.
I want the user should be having a clear reason for getting an OnDemand Instance.

Regards
AK

[res0nance]

Not quite, the fourth parameter is spotWithoutBidPrice so it is still spot.
See

ec2-plugin/src/main/java/hudson/plugins/ec2/SlaveTemplate.java

Lines 1092 to 1143 in b4a6e1e

	private List<EC2AbstractSlave> provisionOndemand(Image image, int number, EnumSet<ProvisionOptions> provisionOptions, boolean spotWithoutBidPrice, boolean fallbackSpotToOndemand)
	throws IOException {
	AmazonEC2 ec2 = getParent().connect();
	logProvisionInfo("Considering launching");
	HashMap<RunInstancesRequest, List<Filter>> runInstancesRequestFilterMap = makeRunInstancesRequestAndFilters(image, number, ec2);
	Map.Entry<RunInstancesRequest, List<Filter>> entry = runInstancesRequestFilterMap.entrySet().iterator().next();
	RunInstancesRequest riRequest = entry.getKey();
	List<Filter> diFilters = entry.getValue();
	DescribeInstancesRequest diRequest = new DescribeInstancesRequest().withFilters(diFilters);
	logProvisionInfo("Looking for existing instances with describe-instance: " + diRequest);
	DescribeInstancesResult diResult = ec2.describeInstances(diRequest);
	List<Instance> orphansOrStopped = findOrphansOrStopped(diResult, number);
	if (orphansOrStopped.isEmpty() && !provisionOptions.contains(ProvisionOptions.FORCE_CREATE) &&
	!provisionOptions.contains(ProvisionOptions.ALLOW_CREATE)) {
	logProvisionInfo("No existing instance found - but cannot create new instance");
	return null;
	}
	wakeOrphansOrStoppedUp(ec2, orphansOrStopped);
	if (orphansOrStopped.size() == number) {
	return toSlaves(orphansOrStopped);
	}
	riRequest.setMaxCount(number - orphansOrStopped.size());
	List<Instance> newInstances;
	if (spotWithoutBidPrice) {
	InstanceMarketOptionsRequest instanceMarketOptionsRequest = new InstanceMarketOptionsRequest().withMarketType(MarketType.Spot);
	if (getSpotBlockReservationDuration() != 0) {
	SpotMarketOptions spotOptions = new SpotMarketOptions().withBlockDurationMinutes(getSpotBlockReservationDuration() * 60);
	instanceMarketOptionsRequest.setSpotOptions(spotOptions);
	}
	riRequest.setInstanceMarketOptions(instanceMarketOptionsRequest);
	try {
	newInstances = ec2.runInstances(riRequest).getReservation().getInstances();
	} catch (AmazonEC2Exception e) {
	if (fallbackSpotToOndemand && e.getErrorCode().equals("InsufficientInstanceCapacity")) {
	logProvisionInfo("There is no spot capacity available matching your request, falling back to on-demand instance.");
	riRequest.setInstanceMarketOptions(new InstanceMarketOptionsRequest());
	newInstances = ec2.runInstances(riRequest).getReservation().getInstances();
	} else {
	throw e;
	}
	}
	} else {

[arunmastermind]

Thats correct but my commit is in here

ec2-plugin/src/main/java/hudson/plugins/ec2/SlaveTemplate.java

Lines 1351 to 1357 in b4a6e1e

	*/
	private List<EC2AbstractSlave> provisionSpot(Image image, int number, EnumSet<ProvisionOptions> provisionOptions)
	throws IOException {
	if (!spotConfig.useBidPrice) {
	return provisionOndemand(image, 1, provisionOptions, true, spotConfig.getFallbackToOndemand());
	}

[res0nance]

Sure, but ultimately the statement No Bidding for Spot, falling back to on-demand instance. is wrong because it will provision a spot instance and if that fails it should log There is no spot capacity available matching your request, falling back to on-demand instance

[res0nance]

I see no point to this, this is clearly configured without spot

[arunmastermind]

yeah thats correct but the end user is not getting any information or reason for "falling back to on demand"
This is a quick change to get some logging which would help the end user.

[res0nance]

The user should have all the information that its not spot because he did not configure spot in the first place. This code respects the setting the user has selected and not due to an edge case we have to fall back to anything.

[arunmastermind]

Thanks for the information. My issue here is, how would i be able to know if i have been assigned OnDemand Instance because of lower bidding or because of exhausted Spot Instances.

[res0nance]

If its exhausted with bidprice you should see There is no spot capacity available matching your request, falling back to on-demand instance.

This change clearly doesn't answer if too low bid or exhausted instances happens because its provisioning ondemand due to lack of configuration. Exactly what the user configured.