reduce number of getPasswordData calls #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to come with the problem that it would increase the time it takes for the node to connect by a large amount |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the AMI was not setup to generate passwords, AWS does not generate passwords. In such cases, ec2 plugin keeps making EC2 api attempting to get the password. This exhausts the allowed EC2 api calls from aws side and AWS starts throttling the api calls, especially if multiple nodes are spun up at the same time.
This PR attempts to address this issue by reducing the frequency of GetPasswordData calls using exponential back off with full jitter.
Here is an example of the log messages printed out:
