Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to the very latest httpd docker image to unbreak tests. #313

Merged

Conversation

Romain-Geissler-1A
Copy link
Contributor

@Romain-Geissler-1A Romain-Geissler-1A commented Apr 27, 2024

Indeed since Docker 26 the image in the old v1 format are no longer run by default (it used to be deprecated but tolerated for years). Fix this by hardcoding the very latest httpd docker image version as of today.

If you are interested by the actual deprecation description on docker side, it's this one: https://docs.docker.com/engine/deprecated/#pushing-and-pulling-with-image-manifest-v2-schema-1

If fixes errors like this that we have with the current non-regressions tests (extracted from your CI: https://ci.jenkins.io/job/Plugins/job/docker-workflow-plugin/job/PR-312/1/pipeline-console/?selected-node=33)

10:52:10  [Pipeline] withEnv
10:52:10  [Pipeline] {
10:52:10  [Pipeline] sh
10:52:10  + docker inspect -f . httpd:2.4.12
10:52:10  
10:52:10  Error: No such object: httpd:2.4.12
10:52:10  [Pipeline] isUnix
10:52:10  [Pipeline] withEnv
10:52:10  [Pipeline] {
10:52:10  [Pipeline] sh
10:52:10  + docker pull httpd:2.4.12
10:52:10  2.4.12: Pulling from library/httpd
10:52:10  [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/httpd:2.4.12 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/
10:52:10  [Pipeline] }
10:52:10  [Pipeline] // withEnv
10:52:10  [Pipeline] }
10:52:10  [Pipeline] // withEnv
10:52:10  [Pipeline] }
10:52:10  [Pipeline] // node
10:52:10  [Pipeline] End of Pipeline
10:52:10  ERROR: script returned exit code 1
10:52:10  Finished: FAILURE

I need this as a pre-requisite for another of my pull requests, but this is independant from my other change.

Testing done

Testing done via your own CI.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@Romain-Geissler-1A Romain-Geissler-1A changed the title Migrate test to the very latest httpd docker image to unbreak tests. Migrate tests to the very latest httpd docker image to unbreak tests. Apr 27, 2024
@Romain-Geissler-1A Romain-Geissler-1A force-pushed the bugfix/use-recent-httpd-test-image branch 3 times, most recently from 4ce854e to def64ae Compare April 27, 2024 11:35
Indeed since Docker 26 the image in the old v1 format are no longer run
by default (it used to be deprecated but tolerated for years). Fix this
by hardcoding the very latest httpd docker image version as of today.
@Romain-Geissler-1A
Copy link
Contributor Author

Friendly ping ;)

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@jglick jglick merged commit c0c3406 into jenkinsci:master May 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants