Fix host directory mounts on Windows #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maass-tv
force-pushed
the
fix_windows_mount
branch
2 times, most recently
from
4e271bf
to
b9fafa4
Compare
On Windows, it is not possible to mount host directories to a subfolder of a non-C: drive. Due to this restriction, having a workspace on another drive will make the docker run execution fail since the plugin tries to map the workspace into the container. This fixes that by collecting all the non-C: drive volume mappings and handling those explicitly by mapping the entire drive into the container.
maass-tv
force-pushed
the
fix_windows_mount
branch
from
b9fafa4
to
4494cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, it is not possible to mount host directories to a subfolder
of a non-C: drive. Due to this restriction, having a workspace on
another drive will make the docker run execution fail since the plugin
tries to map the workspace into the container.
This fixes that by collecting all the non-C: drive volume mappings and
handling those explicitly by mapping the entire drive into the
container.