fix: Port binding is not respected for SSH port

[ericlapier]

1- Dashboard > Manage Jenkins > Configure Clouds
2- Add a new Cloud
3- Connect method SSH
4- Container settings
5- Port Bindings
0.0.0.0:20000-20100:22
Expected Results
All docker-proxy process should use a port between 20000 and 20100

Tested for a year now with this fix and docker-proxy always gets a port in the specified range.

Testing done

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[krisstern]

The code change proposed looks sensible enough. Thanks @ericlapier for the contribution!

[krisstern]

I have just checked the official doc at https://docs.docker.com/network/proxy/. It does not seem to have a prescribed port range. Also, some of the CI/CD tests are not passing. May I ask if this port range is used by your company for a particular network configuration? If we accept this PR many users will be impacted I am afraid.

[ericlapier]

no particular network configuration. We have other software running on the slaves, and if we don't specify a range, allocated ssh port start to collide with running daemons.

…

On Fri, Mar 8, 2024 at 11:26 AM Kris Stern ***@***.***> wrote: I have just checked the official doc at https://docs.docker.com/network/proxy/. It does not seem to have a prescribed port range. Also, some of the CI/CD tests are not passing. May I ask if this port range is used by your company for a particular network configuration? If we accept this PR many users will be impacted I am afraid. — Reply to this email directly, view it on GitHub <#1043 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BFR3ROVNEJ5UQNTVTMKVY7DYXHRDFAVCNFSM6AAAAABCHYCFQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGAYDANRUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- .

[krisstern]

We cannot approve the PR until the CI/CD checks are passing. @ericlapier Could you please get this done first?

[ericlapier]

@krisstern I added a new testcase and fix the code such that all testcases are now successful.

[krisstern]

Thanks @ericlapier! The PR looks good to me. I will have it merged over the next 24 hours if I do not see any major objections from anyone.

[krisstern]

LGTM