Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require minimum Jenkins 2.414.3 #222

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jonesbusy
Copy link
Contributor

Hi,

Latest release is pulling deprecated dependencies (see bellow)

copyartifact depends on:
matrix-project 802.v8013b_40c7edc
matrix-project depends on:
junit 1189.v1b_e593637fa_e
...
junit depends on:
bootstrap5-api 5.2.1-3
...
bootstrap5-api depends on:
font-awesome-api 6.2.0-3
popper2-api 2.11.6-1 <-- This is deprecated and don't want this

A release will be appreciated

Testing done

Only automated tests

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@jonesbusy jonesbusy requested a review from a team as a code owner March 15, 2024 08:26
@jonesbusy
Copy link
Contributor Author

I think it's also some issues of the plugin-installation manager.

I have all plugins installed to latest version (but I'm installing copyartifact afterward. Because popper2-api is not anymore installed on my instance (no plugin depends anymore on it) copartifact still pull it

Will install new plugin popper2-api 2.11.6-1
Will install new plugin copyartifact 722.v0662a_9b_e22a_c
Will use url: https://<internal repo>/artifactory/<repo>/download/plugins/copyartifact/722.v0662a_9b_e22a_c/copyartifact.hpi to download copyartifact plugin
Will use url: https://<internal repo>/artifactory/<repo>/download/plugins/popper2-api/2.11.6-1/popper2-api.hpi to download popper2-api plugin

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the chore Reduce maintenance or improve developer experience label Mar 15, 2024
@MarkEWaite MarkEWaite merged commit e23cf29 into jenkinsci:master Mar 15, 2024
16 checks passed
@MarkEWaite
Copy link
Contributor

I don't think that a new release of the copyartifact plugin will solve the issue that you are seeing. The issue is in the plugin installation manager and the arguments that you are passing to it.

I use a plugins.txt file that lists the precise version of every plugin that is to be installed so that I don't rely on the plugin installation manager tool to resolve transitive dependencies. That avoids the problem because in my list of plugins I have bootstrap5-api:5.3.3-1 rather than the older dependency that is declared by the junit plugin.

An issue has been reported for the plugin installation manager tool, but I'm not sure that there is a viable, compatible solution for it without adding a new mode or a new set of options. See the issue at:

@jonesbusy jonesbusy deleted the feature/update-core-version branch March 15, 2024 13:45
@jonesbusy
Copy link
Contributor Author

jonesbusy commented Mar 15, 2024

Hi,

I have 2 steps installation (list of plugin on a base image) and then extra plugin installed via the jenkins helm chart

installPlugins:
   - copyartifact:722.v0662a_9b_e22a_c

Well at the end I was able to workaround the issue be "reinstalling" the bootstrap5-api

installPlugins:
  - copyartifact:722.v0662a_9b_e22a_c
  - bootstrap5-api:5.3.3-1

But yes the point is that the plugin installation manager is doing the dependency resolution based in the inputs (plugin.txt or CLI) and not what is actually installed already on the instance. It can cause that a plugin is installed when it shouldn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduce maintenance or improve developer experience
Projects
None yet
2 participants