Skip to content

Commit

Permalink
Revert "Bump maven-plugin from 3.16 to 3.21" (#181)
Browse files Browse the repository at this point in the history
* Revert "Bump maven-plugin from 3.16 to 3.21"

* Explain maven plugin version pin in a comment

jenkinsci/bom#1978 notes that the upgrade of
the optional dependency on the maven plugin from 3.16 to 3.21 caused
the Jenkins plugin bill of materials to need an explicit inclusion of
the Jenkins maven plugin into the plugin BOM.

That's not a desired change because the Jenkins maven plugin tests do
not pass when run in the Jenkins plugin BOM test suites.  We don't
want to invest the effort in the Jenkins maven plugin tests to make
them work in the Jenkins plugin BOM.

The #174
dependabot proposed upgrade is being reverted to avoid the problem.
When dependabot next proposes an upgrade of this dependency, it can be
closed or evaluated as an incremental build in the Jenkins plugin BOM
before the upgrade is approved.
  • Loading branch information
MarkEWaite committed Apr 21, 2023
1 parent 12c6e8c commit 393f578
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pom.xml
Expand Up @@ -51,7 +51,10 @@
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>maven-plugin</artifactId>
<version>3.21</version>
<!-- Intentionally kept at 3.16 to not disrupt Jenkins plugin bill of materials -->
<!-- https://github.com/jenkinsci/bom/pull/1978#issuecomment-1516220549 -->
<!-- TODO: Before upgrading this version, must check that plugin bill of materials is unharmed -->
<version>3.16</version>
<optional>true</optional>
</dependency>
<dependency>
Expand Down

0 comments on commit 393f578

Please sign in to comment.